Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in spellings of CANCELED #209

Merged
merged 4 commits into from
May 10, 2023
Merged

Fixed typo in spellings of CANCELED #209

merged 4 commits into from
May 10, 2023

Conversation

ateev
Copy link
Contributor

@ateev ateev commented May 9, 2023

Currently the API supports only CANCELED and not CANCELLED. This PR fixes the SDK to send correct key

@darekg11
Copy link
Contributor

darekg11 commented May 9, 2023

Hello @ateev You are right, thanks for the contribution.
Couple of required changes:

@ateev
Copy link
Contributor Author

ateev commented May 9, 2023

done @darekg11

@darekg11 darekg11 self-requested a review May 9, 2023 10:26
@darekg11 darekg11 merged commit dd1601d into voucherifyio:main May 10, 2023
@github-actions github-actions bot mentioned this pull request May 10, 2023
Merged
@darekg11
Copy link
Contributor

@ateev thanks for the fixes and thanks again for contribution.

Pull Request that triggered new version release: #210

Fix is included in version 2.2.2 and it should be available in NPM registry shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darekg11 darekg11 darekg11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ateev @darekg11